[Beta] Fix preconnect link to target search cluster#3980
Merged
nearestnabors merged 1 commit intoreactjs:betafrom Oct 23, 2021
Merged
[Beta] Fix preconnect link to target search cluster#3980nearestnabors merged 1 commit intoreactjs:betafrom
nearestnabors merged 1 commit intoreactjs:betafrom
Conversation
The `appId` was retrieved from props but the `<Search>` component is never instantiated with props. So the preconnect link targeted an unknown search cluster: ```html <link rel="preconnect" href="https://undefined-dsn.algolia.net" crossorigin="true"> ``` This fixes the preconnect link by getting the `appId` from the website config.
francoischalifour
changed the title
Contributor
|
|
gaearon
pushed a commit
that referenced
this pull request
Oct 28, 2021
The `appId` was retrieved from props but the `<Search>` component is never instantiated with props. So the preconnect link targeted an unknown search cluster: ```html <link rel="preconnect" href="https://undefined-dsn.algolia.net" crossorigin="true"> ``` This fixes the preconnect link by getting the `appId` from the website config.
gaearon
pushed a commit
that referenced
this pull request
Oct 28, 2021
The `appId` was retrieved from props but the `<Search>` component is never instantiated with props. So the preconnect link targeted an unknown search cluster: ```html <link rel="preconnect" href="https://undefined-dsn.algolia.net" crossorigin="true"> ``` This fixes the preconnect link by getting the `appId` from the website config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
appIdwas retrieved from props but the<Search>component is never instantiated with props. So the preconnect link targeted an unknown search cluster:This fixes the preconnect link by getting the
appIdfrom the website config.